Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed space between space between the KASP and View CNS button in facility card #5578

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fixed space between space between the KASP and View CNS button in facility card #5578

merged 2 commits into from
Jun 6, 2023

Conversation

satyam0601
Copy link
Contributor

@satyam0601 satyam0601 commented Jun 1, 2023 •
edited by ghost
Loading

WHAT

Minor bug in UI of Facility Card there is no space between the KASP and View CNS button

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 80a45d7

  • Add a left margin to the KASP badge on the facility card to improve alignment and readability (link)

@satyam0601 satyam0601 requested a review from a team June 1, 2023 10:38
@satyam0601 satyam0601 requested a review from a team as a code owner June 1, 2023 10:38
@satyam0601 satyam0601 requested a review from bodhish June 1, 2023 10:38
@vercel
Copy link

vercel bot commented Jun 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 7:12am

@netlify
Copy link

netlify bot commented Jun 1, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0c173f4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647d8ab15787f000081c9441
😎 Deploy Preview https://deploy-preview-5578--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2023

LGTM

@khavinshankar khavinshankar merged commit c1d3f56 into coronasafe:develop Jun 6, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor bug in UI of Facility Card
4 participants
@satyam0601 @nihal467 @rithviknishad @khavinshankar