Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3585 #5590

Closed
wants to merge 1 commit into from
Closed

Issue #3585 #5590

wants to merge 1 commit into from

Conversation

NimbleNitesh
Copy link

@NimbleNitesh NimbleNitesh commented Jun 3, 2023

WHAT

The fields in ONVIF camera and HL7 monitor asset page are not mandatory
image
image

Proposed Changes

  • Fixes Make mandatory validation in ONVIF camera and HL7 monitor asset page #3585
  • In ONVIFCamera.tsx
    • Added the required attribute to the TextFormField components for the fields "Hospital Middleware Hostname," "Local IP Address," "Username," "Password," and "Stream UUID" to make them required fields.
    • Added a validation check in the handleSubmit function to ensure all the required fields are filled. If any required field is empty, an error notification is shown, and the form submission is prevented.
    • Added a validation check in the handleSubmit function to validate the IP address entered in the "Local IP Address" field using the checkIfValidIP function. If the IP address is not valid, an error message is displayed, and the form submission is prevented.
  • In HL7 Montior.tsx
    • Added the required attribute to the TextFormField component for that field.
      image
      image
      image
      image
      image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3b11517

  • Fix typo and add required attribute to middleware hostname text field in HL7Monitor.tsx (link, link)
  • Remove empty line in HL7Monitor.tsx (link)
  • Rename and validate state variable for IP address error in ONVIFCamera.tsx (link, link, link)
  • Add error handling and notification logic to handleSubmit function in ONVIFCamera.tsx (link, link, link)
  • Add required attributes to stream UUID, camera address, username, and password text fields in ONVIFCamera.tsx (link, link, link, link, link)
  • Remove unnecessary Promise.resolve wrapper and extra dots from error messages in ONVIFCamera.tsx (link, link)
  • Remove empty line in ONVIFCamera.tsx (link)

@NimbleNitesh NimbleNitesh requested a review from a team June 3, 2023 05:52
@NimbleNitesh NimbleNitesh requested a review from a team as a code owner June 3, 2023 05:52
@NimbleNitesh NimbleNitesh requested a review from gigincg June 3, 2023 05:52
@vercel
Copy link

vercel bot commented Jun 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 5:53am

@netlify
Copy link

netlify bot commented Jun 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3b11517
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647ad51aa8fff40008673934
😎 Deploy Preview https://deploy-preview-5590--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mandatory validation in ONVIF camera and HL7 monitor asset page
1 participant