Make mandatory validation in ONVIF camera and HL7 monitor asset page #3585

[NimbleNitesh]

WHAT

The fields in ONVIF camera and HL7 monitor asset page are not mandatory

Proposed Changes

• Fixes Make mandatory validation in ONVIF camera and HL7 monitor asset page #3585
• In ONVIFCamera.tsx
  • Added the required attribute to the TextFormField components for the fields "Hospital Middleware Hostname," "Local IP Address," "Username," "Password," and "Stream UUID" to make them required fields.
  • Added a validation check in the handleSubmit function to ensure all the required fields are filled. If any required field is empty, an error notification is shown, and the form submission is prevented.
  • Added a validation check in the handleSubmit function to validate the IP address entered in the "Local IP Address" field using the checkIfValidIP function. If the IP address is not valid, an error message is displayed, and the form submission is prevented.
• In HL7 Montior.tsx
  • Added the required attribute to the TextFormField component for that field.
    
    
    
    
    

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

HOW

🤖 Generated by Copilot at 3b11517

• Fix typo and add required attribute to middleware hostname text field in HL7Monitor.tsx (link, link)
• Remove empty line in HL7Monitor.tsx (link)
• Rename and validate state variable for IP address error in ONVIFCamera.tsx (link, link, link)
• Add error handling and notification logic to handleSubmit function in ONVIFCamera.tsx (link, link, link)
• Add required attributes to stream UUID, camera address, username, and password text fields in ONVIFCamera.tsx (link, link, link, link, link)
• Remove unnecessary Promise.resolve wrapper and extra dots from error messages in ONVIFCamera.tsx (link, link)
• Remove empty line in ONVIFCamera.tsx (link)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2023 2:14pm

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	c0d1c07
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/647b4a7c1e3be40008c00b4c
😎 Deploy Preview	https://deploy-preview-5592--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Ashesh3]

We do not want such error notifications for missing fields. Instead, maintain a state which will store all field related errors. Then, Just after e.preventDefault(); here, call a validateForm method which will loop through all the fields we have and check for their validity and if they are invalid (missing), then update the error state with the field name with the error, errors[field] = "Please select the xxx field";. Have this error state linked to all the TextFormField as <TextFormField ..... error={state.errors['field_name']}. So we will have a red text box below the input with the error.

Take reference from UserAdd.tsx

Required error message design (sample):

Current error message design on this PR:

Suggestion by @nihal467 . Feel free to ask any clarifications on this.

[nihal467]

@NimbleNitesh

[github-actions]

👋 Hi, @NimbleNitesh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[github-actions]

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

[github-actions]

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.