Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index field added as key to remove warnings #5601

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

mecskyverse
Copy link
Contributor

WHAT

In .map Methods of Files Export.tsx and HospitalList.tsx there is no key prop which is causing wanings in the console.

Proposed Changes

  • Fixes key Warnings in .map methods #5600
  • added Key Prop with index in Method of exportItems.map() in ExportList.tsx
  • added Key Prop with index in Method of data.map in HospitalList.tsx

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@mecskyverse mecskyverse requested a review from a team June 5, 2023 07:41
@mecskyverse mecskyverse requested a review from a team as a code owner June 5, 2023 07:41
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 5:46am

@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f44310c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c9ed7f89f0f400086518bf
😎 Deploy Preview https://deploy-preview-5601--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mecskyverse
Copy link
Contributor Author

Using the index as a key prop was a bad Idea. I will be updating with a new field if possible or else I will delete the pull request.

@nihal467
Copy link
Member

nihal467 commented Jun 12, 2023

@khavinshankar @rithviknishad @Ashesh3 can anyone review it

src/Components/Common/Export.tsx Outdated Show resolved Hide resolved
src/Components/Facility/HospitalList.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 22, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jun 29, 2023
@khavinshankar khavinshankar reopened this Jul 18, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

@khavinshankar can you review and merge it

@khavinshankar khavinshankar merged commit df2f476 into coronasafe:develop Aug 2, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key Warnings in .map methods
4 participants