Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI fix on facilities page #5605

Merged
merged 3 commits into from
Jun 7, 2023
Merged

UI fix on facilities page #5605

merged 3 commits into from
Jun 7, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jun 5, 2023 •
edited by ghost
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 9a832dc

  • Change the tooltip position for the live patients / total beds indicator from right to bottom (link). This avoids overlapping with the facility name in the FacilityCard.tsx component and improves readability and usability.

@Pranshu1902 Pranshu1902 requested a review from a team June 5, 2023 20:21
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 5, 2023 20:21
@Pranshu1902 Pranshu1902 requested a review from bodhish June 5, 2023 20:21
@vercel
Copy link

vercel bot commented Jun 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 7:14am

@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5f1fd9c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647edc941450e30008f8d878
😎 Deploy Preview https://deploy-preview-5605--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jun 7, 2023

LGTM

@khavinshankar khavinshankar merged commit 84d1d01 into ohcnetwork:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI fix on Facilities page
3 participants
@Pranshu1902 @nihal467 @khavinshankar