Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Material UI components to CAREUI #5607

Closed

Conversation

abhishekchauhan15
Copy link

@abhishekchauhan15 abhishekchauhan15 commented Jun 6, 2023

WHAT

Replaced Material UI and legacy form fields in the external result update page. Radio buttons created using RadioFormField

🤖 Generated by Copilot at 6b0f415

Refactor UI components in DailyRounds.tsx to use custom components and fix a missing closing tag. This improves the code quality and readability of the patient daily rounds feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 6b0f415

  • Replace material-ui components with custom components for better UI consistency and reusability (link, link, link, link)

@abhishekchauhan15 abhishekchauhan15 requested a review from a team June 6, 2023 14:20
@abhishekchauhan15 abhishekchauhan15 requested a review from a team as a code owner June 6, 2023 14:20
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 2:21pm

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6b0f415
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647f4094d1ab210008d52199
😎 Deploy Preview https://deploy-preview-5607--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishekchauhan15 you've not replaced any of the legacy components.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@rithviknishad
Copy link
Member

@abhishekchauhan15 closing this as of no activity. I'm taking up the issue and I will make a PR for the same to speed up removal of MUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/DailyRounds.tsx:
2 participants