Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds DischargeModal.tsx #5619

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 7, 2023

WHAT

🤖 Generated by Copilot at 2d36aaa

Improved the loading indicator in the DischargeModal component by using a custom CircularProgress component. This change affects the file src/Components/Facility/DischargeModal.tsx.

Proposed Changes

  • Replaced import of CircularProgress from mui to careui

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 2d36aaa

  • Replace CircularProgress component from @material-ui/core with a custom component from ../Common/components/CircularProgress in DischargeModal.tsx (link,link,link)

@rithviknishad rithviknishad requested a review from a team June 7, 2023 19:37
@rithviknishad rithviknishad requested a review from a team as a code owner June 7, 2023 19:37
@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 6:23am

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cf1642b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648173988f19a50008ffc7e5
😎 Deploy Preview https://deploy-preview-5619--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 7, 2023
@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Jun 9, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3f4dc21 into develop Jun 12, 2023
29 checks passed
@khavinshankar khavinshankar deleted the tailwind/DischargeModal.tsx branch June 12, 2023 12:23
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants