Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cypress test for adding doctor's note. #5620

Closed
wants to merge 1 commit into from
Closed

Added Cypress test for adding doctor's note. #5620

wants to merge 1 commit into from

Conversation

SahilSingh177
Copy link
Contributor

@SahilSingh177 SahilSingh177 commented Jun 7, 2023 •
edited
Loading

WHAT

Added test that adds doctor's note to a patient and verifies if the note has been added successfully.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@SahilSingh177 SahilSingh177 requested a review from a team June 7, 2023 21:13
@SahilSingh177 SahilSingh177 requested a review from a team as a code owner June 7, 2023 21:13
@vercel
Copy link

vercel bot commented Jun 7, 2023

@SahilSingh177 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e2c5232
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6492cde4461484000780fe6e
😎 Deploy Preview https://deploy-preview-5620--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SahilSingh177
Copy link
Contributor Author

@SahilSingh177 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

I encountered the same issue with my previous pull request and it did not occur earlier. What could be causing this?

@rithviknishad
Copy link
Member

@SahilSingh177 you can ignore that. Outside collaborators needs approval to get preview deploys on vercel. However, we are using vercel deployments in this repo only for CareUI storybook.

@SahilSingh177 SahilSingh177 force-pushed the Add_doctor_notes branch 5 times, most recently from 2846942 to d3f2e92 Compare June 10, 2023 10:35
@vercel
Copy link

vercel bot commented Jun 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 10:17am

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 13, 2023
@github-actions
Copy link

👋 Hi, @SahilSingh177,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

rithviknishad commented Jun 13, 2023 •
edited
Loading

@SahilSingh177 could you refrain from force pushing?

@SahilSingh177
Copy link
Contributor Author

SahilSingh177 commented Jun 13, 2023 •
edited
Loading

I'm sorry. I didn't want this PR to have too many unnecessary commits for merging. I won't be force pushing now.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 14, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions
Copy link

👋 Hi, @SahilSingh177,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@SahilSingh177
Added Cypress test for adding doctor's note.
e2c5232 
Added test that adds doctor's note to a patient and verifies if
the note has been added successfully.

Fixes coronasafe#4235
@SahilSingh177 SahilSingh177 force-pushed the Add_doctor_notes branch 2 times, most recently from 2c300ea to b83325c Compare June 21, 2023 10:15
@SahilSingh177 SahilSingh177 reopened this Jun 21, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypress: Add doctor's note to a patient page
2 participants
@SahilSingh177 @rithviknishad