Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds SampleFilters.tsx #5630

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Tailwinds SampleFilters.tsx #5630

merged 3 commits into from
Jun 12, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 8, 2023

WHAT

🤖 Generated by Copilot at ce8b1e7

The pull request improves the filter UI for patient samples and fixes a type mismatch issue with the sample_type query parameter. It uses custom form field components, simplifies the state management, and changes the id property of the SAMPLE_TYPE_CHOICES array from a number to a string in src/Common/constants.tsx and src/Components/Patient/SampleViewAdmin.tsx.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at ce8b1e7

  • Change the id property of the SAMPLE_TYPE_CHOICES array from a number to a string to match the sample_type query parameter (link)
  • Replace the LegacySelectField components with the SelectFormField components in the sample filter UI to use custom form fields with consistent styles and props (link, link)
  • Simplify the handleChange function in SampleFilters.tsx to use the FieldChangeEvent type and the useMergeState hook (link, link)
  • Import the CircularProgress, FieldLabel, SelectFormField components and the FieldChangeEvent type from custom files instead of external libraries in SampleFilters.tsx (link)
  • Add a console log statement to debug the sample_type filter value in SampleFilters.tsx (link)
  • Remove the className prop from the FacilitySelect component in SampleFilters.tsx as it was not needed (link)
  • Compare the id property of the SAMPLE_TYPE_CHOICES array with the sample_type query parameter as a string in SampleViewAdmin.tsx to match the change in link (link)

@rithviknishad rithviknishad requested a review from a team June 8, 2023 18:42
@rithviknishad rithviknishad requested a review from a team as a code owner June 8, 2023 18:42
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 8:44am

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fae19c3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648437987a21fe000857f609
😎 Deploy Preview https://deploy-preview-5630--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 8, 2023
@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Jun 10, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit e48cdab into develop Jun 12, 2023
28 of 29 checks passed
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad deleted the tailwind/4982 branch July 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/SampleFilters.tsx:
3 participants