-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cypress test for asset creation #5632
Conversation
…haa/care_fe into cypress-patient-creation
@ShivamJhaa is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@nihal467 @khavinshankar Please review the PR. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ShivamJhaa The cypress test run by the GitHub action uses a dedicated backend, with dummy data loaded to it, it is only having facilities named "Dummy Facility 1" and "Dummy Shifting Center". Currently, I have updated it, but next time make sure you use those facilities only :) |
@ShivamJhaa there is a failure in cypress, check it |
Strangely, the test was passing on Cl even when I was using the local backend data. |
@nihal467 Please review it, the tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShivamJhaa before pushing the PR, make sure that you revert the changes you are making in vite.config.ts to run your own backend
Sure, will keep this in mind, thanks! |
LGTM |
@nihal467 can u review and approve this pr |
WHAT
Added cypress test for asset creation
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at dec2ae0
data-testid
attributes to various input fields and buttons inAssetCreate.tsx
andAssetsList.tsx
to enable locating them in test cases (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)assets.cy.ts
that fills in the required fields and verifies the success notification (link)uuid
module inassets.cy.ts
andvite.config.ts
to generate unique identifiers for the asset QR codes in the test cases (link, link)require
invite.config.ts
(link)patient_crud.cy.ts
(link)