Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the tooltip to use Care's custom components and replacing the PageTitle with Page component. #5640

Closed

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Jun 9, 2023

WHAT

🤖 Generated by Copilot at d228bbe

Refactored the inventory log UI to use common components. This change enhances the code quality and the user experience of the facility inventory log page.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@yogeshbhutkar yogeshbhutkar requested a review from a team June 9, 2023 12:48
@yogeshbhutkar yogeshbhutkar requested a review from a team as a code owner June 9, 2023 12:48
@vercel
Copy link

vercel bot commented Jun 9, 2023

@yogeshbhutkar is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d228bbe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64831fa5331511000801dbf0
😎 Deploy Preview https://deploy-preview-5640--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer #5006 on how to replace some components.

To add tooltip to a button, use ButtonV2 and set it's tooltip and tooltipClass props.

@@ -146,8 +146,8 @@ export default function InventoryLog(props: any) {
</p>
</td>
<td>
<Tooltip
title={
<ToolTip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom tooltip component also is deprecated if you've read the doc comments of that component. Refer #5006 on how to replace each component properly.

For tooltip we are using classes over component because, less JSX the better!

</button>
</Tooltip>
)}
<button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've to replace this button with ButtonV2

className="btn btn-default"
>
<span className="text-red-500">
<i className="fas fa-exclamation-circle pr-2"></i>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font-awesome icons can be migrated to use CareIcons.

@rithviknishad
Copy link
Member

Also, update the PRs title to be something meaningful like what your PR does. And it's nice to have screenshots too!

@yogeshbhutkar yogeshbhutkar changed the title Feature branch 1 Updating the tooltip to use Care's custom components and replacing the PageTitle with Page component. Jun 9, 2023
@yogeshbhutkar yogeshbhutkar deleted the featureBranch-1 branch June 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Facility/InventoryLog.tsx:
2 participants