-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the tooltip to use Care's custom components and replacing the PageTitle with Page component. #5640
Conversation
@yogeshbhutkar is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer #5006 on how to replace some components.
To add tooltip to a button, use ButtonV2
and set it's tooltip
and tooltipClass
props.
@@ -146,8 +146,8 @@ export default function InventoryLog(props: any) { | |||
</p> | |||
</td> | |||
<td> | |||
<Tooltip | |||
title={ | |||
<ToolTip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom tooltip component also is deprecated if you've read the doc comments of that component. Refer #5006 on how to replace each component properly.
For tooltip we are using classes over component because, less JSX the better!
</button> | ||
</Tooltip> | ||
)} | ||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've to replace this button
with ButtonV2
className="btn btn-default" | ||
> | ||
<span className="text-red-500"> | ||
<i className="fas fa-exclamation-circle pr-2"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font-awesome icons can be migrated to use CareIcon
s.
Also, update the PRs title to be something meaningful like what your PR does. And it's nice to have screenshots too! |
WHAT
🤖 Generated by Copilot at d228bbe
Refactored the inventory log UI to use common components. This change enhances the code quality and the user experience of the facility inventory log page.
Proposed Changes
src/Components/Facility/InventoryLog.tsx
: #4957@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers