Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handled the Rhythm card when no data is present #5641

Merged
merged 9 commits into from
Jun 21, 2023
Merged

Handled the Rhythm card when no data is present #5641

merged 9 commits into from
Jun 21, 2023

Conversation

nikhilagastya
Copy link
Contributor

@nikhilagastya nikhilagastya requested a review from a team June 9, 2023 13:16
@nikhilagastya nikhilagastya requested a review from a team as a code owner June 9, 2023 13:16
@vercel
Copy link

vercel bot commented Jun 9, 2023

@nikhilagastya is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d1b10f6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64916e1c455e2600083ca191
😎 Deploy Preview https://deploy-preview-5641--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Jun 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 9:16am

@nihal467
Copy link
Member

@nikhilagastya
image
image

make it center aligned

@nikhilagastya
Copy link
Contributor Author

can you review it once @nihal467 !

@nihal467
Copy link
Member

nihal467 commented Jun 13, 2023 •
edited
Loading

@nikhilagastya
image

currently, when there is data, there is a lot of white space coming in both side

@Ashesh3 can you review and post a change request

@nikhilagastya
Copy link
Contributor Author

@nihal467 @Ashesh3 @rithviknishad is it okay now ?

@nihal467
Copy link
Member

@rithviknishad @nikhilagastya
image

the bug still persist

@Ashesh3
Copy link
Member

Ashesh3 commented Jun 20, 2023

@nihal467 Made the changes.

image
image

image
image
image

@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@Ashesh3 @rithviknishad can you review this pr again

@khavinshankar khavinshankar merged commit d67c0f9 into ohcnetwork:develop Jun 21, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the patient has no rhythm the card is fully empty
6 participants
@nikhilagastya @nihal467 @Ashesh3 @khavinshankar @rithviknishad @patelaryan7751