Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to CareUI components in ResourceDetailsUpdate.tsx component #5647

Merged
merged 16 commits into from
Jun 28, 2023
Merged

Migrating to CareUI components in ResourceDetailsUpdate.tsx component #5647

merged 16 commits into from
Jun 28, 2023

Conversation

MayaSatishRao
Copy link
Contributor

@MayaSatishRao MayaSatishRao commented Jun 12, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 5855b3a

This pull request improves the user interface and experience of the consultation and resource management features, and fixes a bug in the AutoCompleteAsync component. It adds a function to show customized notification messages in ConsultationForm.tsx, refactors ResourceDetailsUpdate.tsx to use the CAREUI library components, and clears the query state and disables the browser's autocomplete in AutoCompleteAsync.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@MayaSatishRao MayaSatishRao requested a review from a team June 12, 2023 17:17
@MayaSatishRao MayaSatishRao requested a review from a team as a code owner June 12, 2023 17:17
@vercel
Copy link

vercel bot commented Jun 12, 2023

@MayaSatishRao is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 12, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4cdf112
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649b1eb23c1c1b000737e0b2
😎 Deploy Preview https://deploy-preview-5647--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad Could u please verify if all the materialUI components are migrated?

@rithviknishad
Copy link
Member

Also update your PR title to something meaningful.

rithviknishad
rithviknishad requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also not migrated PageTitle component

@MayaSatishRao MayaSatishRao changed the title Careuimigrate Migrating to CareUI components in ResourceDetailsUpdate.tsx component Jun 12, 2023
@MayaSatishRao
Copy link
Contributor Author

MayaSatishRao commented Jun 12, 2023 •
edited
Loading

I have made the requested changes @rithviknishad

rithviknishad
rithviknishad approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could have passed the classNames directly to the Form field components instead of wrapping it in a div and specifying it there. Code would have looked cleaner!

@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:39pm

rithviknishad
rithviknishad requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayaSatishRao use the new UserAutocompleteFormField by merging latest develop

@rithviknishad
Copy link
Member

@MayaSatishRao any updates on this?

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad I have made the changes.

rithviknishad
rithviknishad requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you have replaced all the MUI components?

@rithviknishad
Copy link
Member

There shouldn't be any imports of material ui

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad i have made the changes. I am still using FieldLabel for FacilitySelect because it does not have label prop. Other than this all other components are from CareUI

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6771e91 into coronasafe:develop Jun 28, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Resource/ResourceDetailsUpdate.tsx:
4 participants
@MayaSatishRao @rithviknishad @nihal467 @khavinshankar