Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds SetInventoryForm.tsx #5656

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Tailwinds SetInventoryForm.tsx #5656

merged 3 commits into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at 4cf4c4d

Refactored the SetInventoryForm component to improve the UI and code quality. Used consistent and reusable components, simplified the logic, and cleaned up the code.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 4cf4c4d

  • Refactor the component to use the new form fields and the custom Card component (link, link, link, link)
  • Remove unused imports of Card, CardContent, and InputLabel from @material-ui/core (link)
  • Replace imports of LegacySelectField and LegacyTextInputField from ../Common/HelperInputFields with imports of SelectFormField and TextFormField from ../Form/FormFields (link)
  • Add imports of Page from ../Common/components/Page, Card from ../../CAREUI/display/Card, and FieldChangeEvent from ../Form/FormFields/Utils (link)
  • Simplify the handleChange function to use the FieldChangeEvent type and dispatch the form update with a single line of code (link)
  • Wrap the JSX returned by the component with the Page component to handle the page title and breadcrumbs, instead of using the PageTitle component and a div with custom classes (link)
  • Use the custom Card component, instead of the @material-ui/core component, to style the form (link)
  • Replace the legacy form fields with the new SelectFormField and TextFormField components, and adjust the form layout to use the grid and col-span classes, instead of the md:grid-cols-2 class (link)
  • Remove commented out code for the offset state, as it was not used in the component (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 15:13
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 15:13
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 10:01am

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bbf068f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6490274db24fdc0008d6f6ef
😎 Deploy Preview https://deploy-preview-5656--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@rithviknishad
image

it is not good in mobile view

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2bf1728 into develop Jun 21, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the tailwind/4958 branch June 21, 2023 06:38
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants