Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind Feed and FeedButton #5659

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Tailwind Feed and FeedButton #5659

merged 4 commits into from
Jun 23, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at 9d7cef4

This pull request adds camera PTZ control and keyboard shortcut tooltip to the feed component in Feed.tsx. It also cleans up the import statements in the same file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 9d7cef4

  • Remove unused import and reorder imports alphabetically in Feed.tsx (link, link)
  • Add useFeedPTZ hook to control camera pan, tilt and zoom functions in feed component (link)
  • Modify FeedCameraPTZHelpButton component to accept custom tooltip placement and class name (link)
  • Replace material-ui Tooltip component with custom ToolTip component for better styling and positioning in FeedCameraPTZHelpButton component (link, link)

@khavinshankar khavinshankar requested a review from a team June 13, 2023 16:00
@khavinshankar khavinshankar requested a review from a team as a code owner June 13, 2023 16:00
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 0:39am

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e476ea4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6493981a82e484000815ede6
😎 Deploy Preview https://deploy-preview-5659--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary replacement?

Remember Tooltip component was deprecated to reduce usage of JSX for something that can be achieved with css alone?

image

@khavinshankar khavinshankar changed the title Tailwind src/Components/Facility/Consultations/Feed Tailwind Feed and FeedButton Jun 14, 2023
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 22, 2023
@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Jun 22, 2023
@khavinshankar khavinshankar merged commit aaf88c1 into develop Jun 23, 2023
28 of 29 checks passed
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix#4964 branch June 23, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
4 participants