Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds LinkFacilityDialog.tsx #5665

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Tailwinds LinkFacilityDialog.tsx #5665

merged 3 commits into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at a8bbfd6

Refactored the LinkFacilityDialog component to use ConfirmDialogV2 and reduce material-ui dependencies. This component enables linking a facility to another user in the src/Components/Users/LinkFacilityDialog.tsx file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a8bbfd6

  • Replace Dialog component with ConfirmDialogV2 component to simplify code and use common styles (link, link, link)
  • Modify title prop to highlight username with strong tag (link)
  • Pass function that calls handleOk with username and facility arguments to onConfirm prop (link)
  • Remove unused imports, functions, and components (link, link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 18:10
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 18:10
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 9:38am

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b708446
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648d7edf45557200088d41e5
😎 Deploy Preview https://deploy-preview-5665--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad changed the title Tailwinds LinkFacilityDialog.tsx Deletes old unused Confirm Link Facility Dialog Jun 17, 2023
@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 5e8db7e
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/648d7b0bb4d6e00008639349

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview cypress failed pull request with cypress test failure and removed cypress passed labels Jun 17, 2023
@rithviknishad rithviknishad changed the title Deletes old unused Confirm Link Facility Dialog Tailwinds LinkFacilityDialog.tsx Jun 17, 2023
@rithviknishad rithviknishad removed Deploy-Failed Deplyment is not showing preview cypress failed pull request with cypress test failure labels Jun 17, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2cd244a into develop Jun 21, 2023
28 checks passed
@khavinshankar khavinshankar deleted the tailwinds/5001 branch June 21, 2023 06:14
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Users/LinkFacilityDialog.tsx:
3 participants