Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Force:true from Cypress Asset Test #5676

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jun 14, 2023

WHAT

🤖 Generated by Copilot at 13e26df

Improve e2e tests for assets by using better selectors and url assertions. Refactor assets.cy.ts file accordingly.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 13e26df

  • Change the phone_number variable to a fixed value to avoid flaky tests (link)
  • Use the role attribute instead of the text content to select the asset location, type, and class options for better accessibility and reliability (link)
  • Use the id attribute instead of the text content to click the next and previous page buttons and add url assertions to verify the pagination (link)

@nihal467 nihal467 requested a review from a team June 14, 2023 10:23
@nihal467 nihal467 requested a review from a team as a code owner June 14, 2023 10:23
@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 10:24am

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 13e26df
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64899537b9cdc70008917724
😎 Deploy Preview https://deploy-preview-5676--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar merged commit 9feca53 into develop Jun 14, 2023
32 of 34 checks passed
@khavinshankar khavinshankar deleted the removedasset-forcetrue branch June 14, 2023 10:32
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants