Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message design on login page #5684

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 15, 2023

WHAT

🤖 Generated by Copilot at b396bc5

Improved the login component UI and code quality by fixing a typo and removing an unnecessary attribute in Login.tsx.

Proposed Changes

Fixes #5683

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b396bc5

  • Fix the error message for the username field to show "field_required" instead of "field_request" (link)
  • Remove the redundant required attribute from the password field, which already has a validation rule (link)

@Ashesh3 Ashesh3 requested a review from a team June 15, 2023 08:24
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 15, 2023 08:24
@Ashesh3 Ashesh3 requested a review from mathew-alex June 15, 2023 08:24
@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 5:55am

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit afaec36
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648d4a8e3b9a3700080679a8
😎 Deploy Preview https://deploy-preview-5684--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 939de66 into coronasafe:develop Jun 20, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the error message consistent in forgot password section
3 participants