Make error messages consistent #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM |
khavinshankar
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 6927078
This pull request improves the error handling and user interface of various form components in the
care_fefrontend. It adds custom error messages and border colors to theAutocomplete,AutocompleteMultiselect, andAutocompleteFormFieldcomponents, and fixes the notification modal in theFacilityCardcomponent.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 6927078
errorprop toAutocompleteFormFieldcomponent to display validation error message for location field in asset creation form (link)notifyErrorstate variable toFacilityCardcomponent to store and display error message for notification modal input field (link, link)notifyErrorstate variable to empty string when notification modal is opened to clear previous error message (link)Notification.Errorfunction call with settingnotifyErrorstate variable to custom error message for notification modal input field (link)errorprop toAutocompleteandAutocompleteMutliSelectcomponents to pass and display validation error message for autocomplete fields (link, link, link, link, link, link, link)border-red-500andborder-danger-500classes toAutocompleteandAutocompleteMutliSelectcomponents to make them more responsive to validation errors (link, link)