Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind LiveFeed.tsx #5718

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Tailwind LiveFeed.tsx #5718

merged 2 commits into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 17, 2023

WHAT

🤖 Generated by Copilot at b0e2a3b

Refactored the live feed page of consultations to use common and custom components. Improved the UI design and user experience by removing clutter and adding confirmation dialogs. Modified the LiveFeed.tsx file and its dependencies.

Proposed Changes

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b0e2a3b

  • Replace Modal and Card components with ConfirmDialogV2 component for confirmation dialogs in live feed page (link)
  • Replace BedSelect and LegacyTextInputField components with FieldLabel component for form field labels in live feed page (link)
  • Adjust layout and styling of dialog content to match design guidelines (link)
  • Replace Tooltip component with custom tooltip element using tailwind classes and CSS variables in live feed page (link)
  • Move tooltip text to a span element inside the button instead of passing as a prop (link)
  • Replace div element with Page component for common layout and header in live feed page (link)
  • Pass hideBack prop to Page component to hide back button in header (link)
  • Remove unused loadable import from LiveFeed.tsx (link)
  • Remove unused imports and add new imports for custom components and native functions in LiveFeed.tsx (link)

@rithviknishad rithviknishad requested a review from a team June 17, 2023 13:52
@rithviknishad rithviknishad requested a review from a team as a code owner June 17, 2023 13:52
@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Jun 17, 2023 1:52pm

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b0e2a3b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648dba96aee14f0008792247
😎 Deploy Preview https://deploy-preview-5718--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0eec833 into develop Jun 21, 2023
33 of 34 checks passed
@khavinshankar khavinshankar deleted the tailwind/4966 branch June 21, 2023 05:59
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Facility/Consultations/LiveFeed.tsx:
3 participants