You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request refactors the FileUpload component to use custom components and the Page component, and adds a custom background color option to the DialogModal component. These changes aim to improve the performance, design, and maintainability of the application.
Replaced Material UI components with Care UI components
Edit 29/06/2023:
Made width of buttons same in mobile view
Fixed the buttons overflowing from its parent component when page width is less(<1280px)
.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Refactor FileUpload component to use custom components instead of Material UI components and legacy components, and to match the design specifications (link, link, link, link, link, link)
Replace PageTitle component with Page component in FileUpload component and its subcomponents, to use a more consistent and flexible layout for the pages (link, link, link)
Add conditional class name to DialogModal component, to allow customizing the background color by passing a bg- class name as a prop (link)
Ok @rithviknishad , that's done. I noticed one more issue. Those buttons are overflowing when width is decreased. I will fix that and create a commit evening after going home
@nihal467 that space is for the error for that field. In existing staging when error comes, layout shift happens. But layout shift is not good, hence new components automatically keeps the spacing consistent to prevent layout shifts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 73b140d
This pull request refactors the FileUpload component to use custom components and the Page component, and adds a custom background color option to the DialogModal component. These changes aim to improve the performance, design, and maintainability of the application.
Proposed Changes
src/Components/Patient/FileUpload.tsx: #4977Edit 29/06/2023:
.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 73b140d
bg-class name as a prop (link)