Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left align Patient heading in mobile view #5724

Closed
wants to merge 4 commits into from

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jun 19, 2023

Proposed Changes

Fixes #5723

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d2a4258

  • Move PageTitle component outside of div element to fix layout issue on smaller screens (link)

@Pranshu1902 Pranshu1902 requested a review from a team June 19, 2023 16:36
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner June 19, 2023 16:36
@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 11:12am

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 998ca64
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6491896a7202c40008cec814
😎 Deploy Preview https://deploy-preview-5724--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Pranshu1902
image

the whole UI is broken in normal view, make sure that you add both view screenshots if you are changing UI, and make this change only in the mobile view

@Pranshu1902
Copy link
Contributor Author

@nihal467 bug resolved!
Desktop view:
image

Mobile view:
image

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions
Copy link

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Pranshu1902
Copy link
Contributor Author

Bug resolved in some other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left Align Patients heading in mobile view
2 participants