added referred to facility field in discharge form #5730

sachdevavaibhav · 2023-06-20T09:31:36Z

WHAT

Added referred to facility field in discharge form

Proposed Changes

Fixes Referred to facility- discharge form #5407

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

HOW

Fetches list of facilities from backend
created facilities local state
used autocomplete component

vercel · 2023-06-20T09:31:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 0:11am

netlify · 2023-06-20T09:31:48Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`570fb40`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/64d3824ee7cdbb000893fa46
😎 Deploy Preview	https://deploy-preview-5730--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sachdevavaibhav · 2023-06-20T09:34:21Z

@rithviknishad Kindly review it. The field can search from the options but it is not able to add values which are not present. Please suggest how can I solve it?

github-actions · 2023-06-23T00:14:52Z

👋 Hi, @sachdevavaibhav,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

sachdevavaibhav · 2023-06-24T17:15:02Z

@rithviknishad @nihal467

rithviknishad

Use FacilitySelect component instead of manually duplicating the facility fetching code.

sachdevavaibhav · 2023-06-28T19:07:06Z

@rithviknishad Kindly review the changes.

rithviknishad

Are you sure this works without any backend changes required?

…vaibhav/coronasafe#5407

sachdevavaibhav · 2023-07-01T18:06:44Z

@rithviknishad
Upon my analysis I found the value is not being stored in the database. Its storing a null value for it.
I found this by setting up care backend locally. It is storing other fields like discharge_reason etc correctly but storing null for referred_to_external.

Kindly see the last sql query in the attached screenshot.

Update:
@rithviknishad
I found in the backend that the data is being received properly but PatientConsultationDischargeSerializer is not having referred_to_external field defined. Upon adding that field everything works fine.

sachdevavaibhav · 2023-07-04T10:28:07Z

@rithviknishad
Should I create issue and link a PR for the backend?

rithviknishad · 2023-07-04T13:28:17Z

@sachdevavaibhav yes! Go ahead!

…vaibhav/coronasafe#5407

github-actions · 2023-08-08T09:39:53Z

👋 Hi, @sachdevavaibhav,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 · 2023-08-08T11:16:48Z

@sachdevavaibhav can you fix the merge conflict and get it ready for testing, we need to get it merge ASAP

sachdevavaibhav · 2023-08-08T11:39:27Z

@sachdevavaibhav can you fix the merge conflict and get it ready for testing, we need to get it merge ASAP

solved merge conflict. Though I have one question why are we using moment.js and day.js both. Don't they serve the same purpose. I have kept the code coming from develop which is using dayjs.

@nihal467 @Ashesh3

rithviknishad · 2023-08-09T06:25:10Z

src/Components/Facility/DischargeModal.tsx

+    const dischargeDetails = {
+      ...preDischargeForm,
+      discharge: value,
+      discharge_date: moment(preDischargeForm.discharge_date).toISOString(true),


@sachdevavaibhav

Merge the latest develop (because moment has been uninstalled)

Discard the package-lock.json diff

replace moment with dayjs

@rithviknishad Kindly review

nihal467 · 2023-08-10T15:08:20Z

LGTM

added referred to facility field in discharge form

5df2c7d

sachdevavaibhav requested a review from a team June 20, 2023 09:31

sachdevavaibhav requested a review from a team as a code owner June 20, 2023 09:31

sachdevavaibhav requested a review from gigincg June 20, 2023 09:31

vercel bot deployed to Preview June 20, 2023 09:32 View deployment

github-actions bot added the merge conflict pull requests with merge conflict label Jun 23, 2023

vercel bot deployed to Preview June 24, 2023 17:11 View deployment

rithviknishad added needs testing and removed merge conflict pull requests with merge conflict labels Jun 24, 2023

rithviknishad requested changes Jun 24, 2023

View reviewed changes

rithviknishad added changes required and removed needs testing labels Jun 24, 2023

sachdevavaibhav added 2 commits June 28, 2023 23:17

merge develop

8f6d0fb

replaced AutoComplete component with FacilitySelect

a074ec9

sachdevavaibhav force-pushed the sachdevavaibhav/#5407 branch from d8a7294 to a074ec9 Compare June 28, 2023 19:02

vercel bot deployed to Preview June 28, 2023 19:03 View deployment

sachdevavaibhav requested a review from rithviknishad June 28, 2023 20:10

rithviknishad requested changes Jun 30, 2023

View reviewed changes

Merge branch 'develop' of github.com:coronasafe/care_fe into sachdeva…

c38452b

…vaibhav/coronasafe#5407

sachdevavaibhav mentioned this pull request Jul 4, 2023

PatientConsultationDischargeSerializer is not having referred_to_external field. coronasafe/care#1429

Closed

Merge branch 'develop' of github.com:coronasafe/care_fe into sachdeva…

6990761

…vaibhav/coronasafe#5407

vercel bot deployed to Preview August 3, 2023 16:40 View deployment

Merge branch 'develop' into sachdevavaibhav/coronasafe#5407

710bc27

vercel bot deployed to Preview August 4, 2023 17:39 View deployment

github-actions bot added the merge conflict pull requests with merge conflict label Aug 8, 2023

Merge branch 'develop' into sachdevavaibhav/coronasafe#5407

9857cc1

vercel bot deployed to Preview August 8, 2023 11:35 View deployment

github-actions bot removed the merge conflict pull requests with merge conflict label Aug 8, 2023

Merge branch 'develop' into sachdevavaibhav/coronasafe#5407

77d141d

vercel bot deployed to Preview August 9, 2023 06:15 View deployment

rithviknishad requested changes Aug 9, 2023

View reviewed changes

rithviknishad added changes required and removed waiting for backend labels Aug 9, 2023

Merge branch 'develop' into sachdevavaibhav/coronasafe#5407

1c3521a

vercel bot deployed to Preview August 9, 2023 08:06 View deployment

replaced moment with dayjs and removed package-lock difference

5f641da

sachdevavaibhav requested a review from rithviknishad August 9, 2023 08:29

vercel bot deployed to Preview August 9, 2023 08:30 View deployment

rithviknishad approved these changes Aug 9, 2023

View reviewed changes

rithviknishad added needs testing and removed changes required labels Aug 9, 2023

Merge branch 'develop' into sachdevavaibhav/coronasafe#5407

570fb40

vercel bot deployed to Preview August 9, 2023 12:11 View deployment

nihal467 added tested and removed needs testing labels Aug 10, 2023

khavinshankar approved these changes Aug 10, 2023

View reviewed changes

khavinshankar merged commit 2340337 into coronasafe:develop Aug 10, 2023
26 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added referred to facility field in discharge form #5730

added referred to facility field in discharge form #5730

sachdevavaibhav commented Jun 20, 2023 •

edited

Loading

vercel bot commented Jun 20, 2023 •

edited

Loading

netlify bot commented Jun 20, 2023 •

edited

Loading

sachdevavaibhav commented Jun 20, 2023

github-actions bot commented Jun 23, 2023

sachdevavaibhav commented Jun 24, 2023

rithviknishad left a comment •

edited

Loading

sachdevavaibhav commented Jun 28, 2023

rithviknishad left a comment

sachdevavaibhav commented Jul 1, 2023 •

edited

Loading

sachdevavaibhav commented Jul 4, 2023

rithviknishad commented Jul 4, 2023

github-actions bot commented Aug 8, 2023

nihal467 commented Aug 8, 2023 •

edited

Loading

sachdevavaibhav commented Aug 8, 2023

rithviknishad Aug 9, 2023 •

edited by Ashesh3

Loading

sachdevavaibhav Aug 9, 2023

nihal467 commented Aug 10, 2023

added referred to facility field in discharge form #5730

added referred to facility field in discharge form #5730

Conversation

sachdevavaibhav commented Jun 20, 2023 • edited Loading

WHAT

Proposed Changes

Merge Checklist

HOW

vercel bot commented Jun 20, 2023 • edited Loading

netlify bot commented Jun 20, 2023 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

sachdevavaibhav commented Jun 20, 2023

github-actions bot commented Jun 23, 2023

sachdevavaibhav commented Jun 24, 2023

rithviknishad left a comment • edited Loading

Choose a reason for hiding this comment

sachdevavaibhav commented Jun 28, 2023

rithviknishad left a comment

Choose a reason for hiding this comment

sachdevavaibhav commented Jul 1, 2023 • edited Loading

sachdevavaibhav commented Jul 4, 2023

rithviknishad commented Jul 4, 2023

github-actions bot commented Aug 8, 2023

nihal467 commented Aug 8, 2023 • edited Loading

sachdevavaibhav commented Aug 8, 2023

rithviknishad Aug 9, 2023 • edited by Ashesh3 Loading

Choose a reason for hiding this comment

sachdevavaibhav Aug 9, 2023

Choose a reason for hiding this comment

nihal467 commented Aug 10, 2023

sachdevavaibhav commented Jun 20, 2023 •

edited

Loading

vercel bot commented Jun 20, 2023 •

edited

Loading

netlify bot commented Jun 20, 2023 •

edited

Loading

rithviknishad left a comment •

edited

Loading

sachdevavaibhav commented Jul 1, 2023 •

edited

Loading

nihal467 commented Aug 8, 2023 •

edited

Loading

rithviknishad Aug 9, 2023 •

edited by Ashesh3

Loading