Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the blue vertical divider present at the start of the vitals canvas #5740

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 21, 2023

WHAT

🤖 Generated by Copilot at 9bb9351

This pull request improves the responsiveness and consistency of the vitals monitor components. It adds a parent div to the HL7PatientVitalsMonitor and VentilatorPatientVitalsMonitor components, and applies the same style and layout to both. This makes them adapt to different screen sizes and look similar.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 9bb9351

  • Align waveform canvas and offline message horizontally or vertically depending on screen size (link, link)

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 7:24pm

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9bb9351
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64934e878260400008ee8e47
😎 Deploy Preview https://deploy-preview-5740--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 21, 2023
@nihal467
Copy link
Member

LGTM

@mathew-alex mathew-alex merged commit b7735ef into develop Jun 21, 2023
28 of 29 checks passed
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-5739 branch June 21, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the blue vertical line present at the start of the vitals waveform
3 participants