Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes phone number field initial state in user filters #5754

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 22, 2023

WHAT

🤖 Generated by Copilot at e24f07a

Removed hardcoded country code from user filter component. This allows users to search for phone numbers without the "+91" prefix and reduces unnecessary API requests.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at e24f07a

  • Remove default and fallback values for phone number filters to avoid sending unnecessary or invalid query parameters to the backend API (link, link, link)

@rithviknishad rithviknishad requested a review from a team June 22, 2023 06:24
@rithviknishad rithviknishad requested a review from a team as a code owner June 22, 2023 06:24
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 6:24am

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e24f07a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6493e909df29950007506433
😎 Deploy Preview https://deploy-preview-5754--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 22, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 26153c9 into develop Jun 22, 2023
33 of 34 checks passed
@khavinshankar khavinshankar deleted the fixes-5743 branch June 22, 2023 11:10
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone number fields are malfunctioning in Users tab
3 participants