Tailwind externalResult ListFilter #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rithviknishad
approved these changes
Jun 22, 2023
Co-authored-by: Rithvik Nishad <mail@rithviknishad.dev>
❌ Deploy Preview for care-net failed.
|
github-actions
bot
added
the
cypress failed
7 tasks
|
LGTM |
khavinshankar
approved these changes
Jun 23, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at c0444d4
This pull request updates the
ListFiltercomponent for external results and adds a newWardAutocompleteFormFieldcomponent for ward selection. The changes aim to improve the code quality and user experience of the frontend application.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at c0444d4
WardAutocompleteFormFieldfor ward selection based on local body (link)ListFiltercomponent (link)ListFiltercomponent to use the new form field components (link)loadingstate variable from theListFiltercomponent, as it is handled internally by the new form field components (link)fieldto reduce the boilerplate code for the text form fields in theListFiltercomponent (link)stateanddistrictproperties to thefilterStateobject to filter the external results by the user's location (link)getDateto simplify the conversion and validation of date values for the date range form fields in theListFiltercomponent (link)LegacyAutoCompleteAsyncFieldandDateRangePickercomponents with the newMultiSelectFormFieldandDateRangeFormFieldcomponents for the local body, ward, and date range filters in theListFiltercomponent (link)LegacyTextInputFieldcomponent with the newTextFormFieldcomponent for the srf_id filter in theListFiltercomponent (link)