Removes usages of Legacy Components that are not covered by #5006 #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
cypress failed
github-actions
bot
added
cypress passed
and removed
cypress failed
|
LGTM |
khavinshankar
approved these changes
Jun 28, 2023
|
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 7debcff
The pull request removes the deprecated
LegacyErrorHelperTextcomponent and replaces it with theFieldErrorTextcomponent for error messages in various forms. It also deletes two unused files:DiagnosisSelect.tsxandExternalResultLocalbodySelector.tsx.Proposed Changes
HelperInputFields.tsx#5762DiagnosisSelectandExternalResultBodySelectorSwitchV2to use newerFieldError(view in: Working Status field of Asset create form)FieldErrorin the consultation form's investigation and procedure builderFieldErrorin the Doctor Capacity FormUserAutocompleteFormFieldinstead of old User select for Assigned to field in Shift update form@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 7debcff
LegacyErrorHelperTextcomponent withFieldErrorTextcomponent to display consistent error messages for form fields (link, link, link, link, link, link, link, link)src/Components/Common/DiagnosisSelect.tsxandsrc/Components/ExternalResult/ExternalResultLocalbodySelector.tsx(link, link)