Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed overflow and wrapping in vitals monitor #5794

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fixed overflow and wrapping in vitals monitor #5794

merged 1 commit into from
Jun 30, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Jun 28, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 68afa78

Improved the responsiveness of the patient vitals monitor UI by changing the grid layout breakpoint for extra large screens in CentralNursingStation.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 68afa78

  • Adjusted the grid layout for the patient vitals monitor component to use two columns on extra large screens instead of large screens (link)

@GokulramGHV GokulramGHV requested a review from a team June 28, 2023 08:03
@GokulramGHV GokulramGHV requested a review from a team as a code owner June 28, 2023 08:03
@GokulramGHV GokulramGHV requested a review from gigincg June 28, 2023 08:03
@vercel
Copy link

vercel bot commented Jun 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 8:04am

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 68afa78
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649be968d0a330000823badf
😎 Deploy Preview https://deploy-preview-5794--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GokulramGHV GokulramGHV added the P1 breaking issue or vital feature label Jun 28, 2023
@nihal467
Copy link
Member

nihal467 commented Jun 30, 2023 •
edited
Loading

LGTM @rithviknishad review it once

@khavinshankar khavinshankar merged commit 38d890f into coronasafe:develop Jun 30, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress passed P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix overflow and wrapping in vitals monitor
4 participants
@GokulramGHV @nihal467 @rithviknishad @khavinshankar