Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make investigation table responsive / scrollable #5812

Merged
merged 6 commits into from
Jul 1, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 1, 2023

WHAT

🤖 Generated by Copilot at 229ce6f

Improved the UI of the TestTable component in the facility investigations page. Made the table more adaptable to different screen sizes and easier to scroll and interact with.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 229ce6f

  • Make the TestTable component more responsive by applying padding and margin only on medium and larger screens (link)
  • Enable horizontal scrolling for the table element inside the TestTable component to avoid cutting off content on smaller screens (link)

@rithviknishad rithviknishad requested a review from a team July 1, 2023 13:15
@rithviknishad rithviknishad requested a review from a team as a code owner July 1, 2023 13:15
@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2023 5:03pm

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f1b8d39
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64a05c31dc7bac0008d53461
😎 Deploy Preview https://deploy-preview-5812--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Jul 1, 2023

@rithviknishad
image

the dropdown is unable to select

image

the value is not fully visible

@nihal467
Copy link
Member

nihal467 commented Jul 1, 2023

LGTM

@khavinshankar khavinshankar merged commit 137a1be into develop Jul 1, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the fix#5809 branch July 1, 2023 17:07
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P2 tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make investigation page responsive
4 participants