Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes filter from being undefined in shifting filters #5819

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 3, 2023

WHAT

🤖 Generated by Copilot at d9b4eac

Fix phone number filter for shifting requests. Use nullish coalescing operator to avoid sending invalid values to the API in ListFilter.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d9b4eac

  • Prevent sending invalid phone number to API filter by adding nullish coalescing operator (link)

@rithviknishad rithviknishad requested a review from a team July 3, 2023 02:31
@rithviknishad rithviknishad requested a review from a team as a code owner July 3, 2023 02:31
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Jul 3, 2023 2:31am

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d9b4eac
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64a233046db2d70008115990
😎 Deploy Preview https://deploy-preview-5819--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2023

LGTM

@khavinshankar khavinshankar merged commit 6ff5330 into develop Jul 4, 2023
29 checks passed
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix#5815 branch July 4, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shifting filters malfunctioning
3 participants