Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional backdrop in slideover component #5821

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

Bhavik-ag
Copy link
Contributor

@Bhavik-ag Bhavik-ag commented Jul 3, 2023

WHAT

🤖 Generated by Copilot at 45ba1b1

Enhanced the SlideOver component with new props to control its appearance and behavior. This allows more flexibility and usability for the modal window feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 45ba1b1

  • Add optional properties to customize slide over appearance and behavior (link)
  • Set default values for new properties in SlideOver component (link)
  • Modify Dialog component to accept a function for onClose prop (link)
  • Use classNames utility to apply conditional CSS classes to backdrop div element (link)

@Bhavik-ag Bhavik-ag requested a review from a team July 3, 2023 04:35
@Bhavik-ag Bhavik-ag requested a review from a team as a code owner July 3, 2023 04:35
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 5:16am

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3453b9c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64a25968bbb45d000872863b
😎 Deploy Preview https://deploy-preview-5821--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2023

existing slideover looks good to me

@Bhavik-ag
Copy link
Contributor Author

existing slideover looks good to me

I am using the SlideOver component for Doctor notes. Because of that we need to make the backdrop optional.

@khavinshankar khavinshankar merged commit baadf62 into coronasafe:develop Jul 4, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional backdrop in slideover component
4 participants