Cypress | Shift Filter | POM Approach #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
cypress failed
github-actions
bot
added
cypress passed
and removed
cypress failed
khavinshankar
approved these changes
Jul 4, 2023
|
@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 6c57369
The pull request refactors the test code for the shifting section filter using a page object class
ShiftingPage. It also addsidattributes to some filter components inFiltersSlideover.tsxto make them easier to locate by the test code. The changes aim to improve the readability, maintainability, and robustness of the test code.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 6c57369
ShiftingPageclass fromcypress/pageobject/Shift/ShiftFilters.tsin the test filecypress/e2e/shifting_spec/filter.cy.ts(link)ShiftingPageclass (link)ShiftingPageclass with methods for accessing and manipulating the filter elements and buttons incypress/pageobject/Shift/ShiftFilters.ts(link)idattributes to the filter buttons in theFiltersSlideovercomponent (link, link)idattribute to the clear and apply filter buttons insrc/CAREUI/interactive/FiltersSlideover.tsx(link)idattribute to the advanced filter button insrc/CAREUI/interactive/FiltersSlideover.tsx(link)