Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discharge_reason to patient filters #5843

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 6, 2023

Backend PR: coronasafe/care#1440

WHAT

🤖 Generated by Copilot at c5e02ea

Added a new feature to filter patients by their discharge reason in the patient list. This required changes to ManagePatients.tsx, PatientFilter.tsx, and constants.tsx to handle the new filter option and pass it to the backend API and the URL.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at c5e02ea

  • Modify OptionsType interface to allow id to be number or string (link)
  • Import DISCHARGE_REASONS constant from src/Common/constants.tsx in ManagePatients.tsx and PatientFilter.tsx (link, link)
  • Add last_consultation_discharge_reason parameter to filter patients by discharge reason in ManagePatients.tsx (link, link, link, link, link)
  • Add SelectMenuV2 component to render dropdown menu for selecting discharge reason in PatientFilter.tsx (link, link, link, link)

@Ashesh3 Ashesh3 requested a review from a team July 6, 2023 11:47
@Ashesh3 Ashesh3 requested a review from a team as a code owner July 6, 2023 11:47
@Ashesh3 Ashesh3 requested a review from vigneshhari July 6, 2023 11:47
@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Jul 6, 2023 11:47am

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c5e02ea
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64a6a9bf7f25ff0007592690
😎 Deploy Preview https://deploy-preview-5843--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jul 6, 2023
@nihal467 nihal467 added the P1 breaking issue or vital feature label Jul 7, 2023
@nihal467
Copy link
Member

nihal467 commented Jul 7, 2023

@khavinshankar the cypress is a random failure due to logout, ignore it, the PR is good to merge

@khavinshankar khavinshankar merged commit 3cfe497 into develop Jul 7, 2023
34 of 36 checks passed
@khavinshankar khavinshankar deleted the issue-5474 branch July 7, 2023 09:45
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for "Discharge Reason Based" filter in Advanced Filters in the Patients Card
3 participants