Replace screenfull package with useFullscreen hook #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
cypress failed
github-actions
bot
added
cypress passed
and removed
cypress failed
|
LGTM |
khavinshankar
approved these changes
Jul 12, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Ashesh3
added a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at b675685
This pull request replaces the
screenfulllibrary with a custom hook for fullscreen functionality in various components. This reduces dependencies, simplifies the code, and allows more flexibility in choosing the fullscreen element. The affected components areFeed.tsx,LiveFeed.tsx, andLiveFeedTile.tsx.Proposed Changes
screenfullpackage and useuseFullscreencustom hook instead #5840@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at b675685
screenfulldependency frompackage.json(link)useFullscreenhook to accept an optionalelementparameter (link)setFullscreenfunction to use native fullscreen methods andelementparameter (link)screenfulllibrary withuseFullscreenhook inFeed.tsx(link, link, link)FeedCameraPTZHelpButtoncomponent (link)screenfulllibrary withuseFullscreenhook inLiveFeed.tsx(link, link, link, link)screenfulllibrary withuseFullscreenhook inLiveFeedTile.tsx(link, link, link)