Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OnlineUsersSelect with Tailwind component #5861

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 10, 2023

WHAT

🤖 Generated by Copilot at ad91773

This pull request enhances the user selection and filtering features in various components of the application. It introduces a new UserAutocompleteFormField component that allows searching users by name, type, and online status, and shows a clear icon to reset the input. It replaces the OnlineUsersSelect component and updates the ConsultationForm and PatientHome components to use the new component. It also refactors the Autocomplete component to use modern JavaScript syntax and features.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at ad91773

  • Replace OnlineUsersSelect component with UserAutocompleteFormField component in ConsultationForm and PatientHome components, to allow filtering user options by user type and showing online status with a circle icon (link, link, link, link, link, link, link, link)
  • Add optional props userType and showActiveStatus to UserAutocompleteFormField component, and use them to conditionally add user_type parameter to getUserList API call and display status icon based on user's last login time using moment library (link, link, link)
  • Use optional chaining operator (?.) to simplify code that invokes optional props onQuery, optionDescription, and optionIcon in Autocomplete component (link, link)
  • Use nullish coalescing operator (??) instead of logical OR operator (||) to avoid replacing falsy values with default values in value, placeholder, and displayValue props of Combobox and Combobox.Input components in Autocomplete component (link, link)
  • Add times-circle icon to Autocomplete component, to allow clearing selected value from input field if not required (link)

@Ashesh3 Ashesh3 requested a review from a team July 10, 2023 16:47
@Ashesh3 Ashesh3 requested a review from a team as a code owner July 10, 2023 16:47
@Ashesh3 Ashesh3 requested a review from bodhish July 10, 2023 16:47
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:38pm

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 77cdaf1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64aed6ae98ccbf00086a7a0e
😎 Deploy Preview https://deploy-preview-5861--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Jul 10, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 11, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jul 11, 2023
@nihal467
Copy link
Member

@Ashesh3 rework on the alignment and clear button as discussed in the huddle

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 12, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 12, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 12, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 7933c9d into develop Jul 21, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the issue-5853 branch July 21, 2023 04:06
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert assign to volunteer pop-up to tailwind
4 participants