Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Code Refactor: ConsultationDetails.tsx #5830 #5885

Closed
wants to merge 4 commits into from

Conversation

nazrul7711
Copy link

@nazrul7711 nazrul7711 commented Jul 18, 2023

WHAT

🤖 Generated by Copilot at 68d8064

The pull request adds several new components to the src/Components/Facility directory, each corresponding to a different tab for displaying consultation data. The components use the ConsultationTabProps type and the Page component from src/Common/constants.tsx. The components render various plots, tables, diagrams, and files related to the consultation, such as blood gas analysis, dialysis, nursing, nutrition, pressure sore, and ventilator data.
The pull request adds several new components to the src/Components/Facility directory, each corresponding to a different tab for displaying consultation data. The components use a common interface defined in src/Common/constants.tsx to receive props from the parent component. The components also import and render various plot, table, and file upload components from other directories. The purpose of the changes is to enhance the user interface and functionality of the consultation feature.
The task was to break ConsultationDetails.tsx files into smaller components.

Proposed Changes

I made the following components.

ConsultationUpdatesTab
ConsultationFeedTab
ConsultationSummaryTab
ConsultationMedicinesTab
ConsultationFilesTab
ConsultationABGTab
ConsultationNursingTab
ConsultationNeurologicalMonitoringTab
ConsultationVentilatorTab
ConsultationNutritionTab
ConsultationPressureSoreTab
ConsultationDialysisTab
ConsultationInvestigationsTab

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 68d8064

  • Create ConsultationTabProps interface to define common props for consultation tabs (link)
  • Import ConsultationModel and PatientModel interfaces to use in props (link)
  • Create ConsultationABGTab component to render arterial blood gas analysis plots (link)
  • Create ConsultationDialysisTab component to render dialysis plots (link)
  • Create ConsultationFeedTab component to render camera feed (link)
  • Create ConsultationFilesTab component to render file upload and view (link)
  • Create ConsultationInvestigationsTab component to render investigations and test results (link)
  • Create ConsultationMedicinesTab component to render prescribed and administered medicines (link)
  • Create ConsultationNeurologicalMonitoringTab component to render neurological monitoring data (link)
  • Create ConsultationNursingTab component to render nursing analysis plot (link)
  • Create ConsultationNutritionTab component to render nutrition plots (link)
  • Create ConsultationPressureSoreTab component to render pressure sore diagrams (link)
  • Create ConsultationSummaryTab component to render primary parameters plot (link)
  • Create ConsultationVentilatorTab component to render respiratory support plot (link)
  • Pass ConsultationTabProps to each tab component as props (link, link, link, link, link, link, link, link, link, link, link, link)
  • Add button to log lab results in ConsultationInvestigationsTab with authorization and navigation logic (link)
  • Use state variable to re-render medicine tables when prescriptions change in ConsultationMedicinesTab (link)
  • Make medicine tables read-only if consultation is discharged in ConsultationMedicinesTab (link)

@nazrul7711 nazrul7711 requested a review from a team July 18, 2023 10:18
@nazrul7711 nazrul7711 requested a review from a team as a code owner July 18, 2023 10:18
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 9:26am

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for care-egov-staging failed.

Name Link
🔨 Latest commit b02b562
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c0e6988f88260008926359

@nazrul7711
Copy link
Author

@rithviknishad Kindly review this PR. I have implemented all the suggested points from previous PR

@rithviknishad rithviknishad linked an issue Jul 18, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 18, 2023
@github-actions
Copy link

👋 Hi, @nazrul7711,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@nazrul7711 can you resolve the merge conflict

@nazrul7711
Copy link
Author

hey @nihal467 I have resolved the conflicts.

@nihal467
Copy link
Member

@nazrul7711 can you clear the merge conflict

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit b02b562
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/64c0e698be5fb600080b4843

@nazrul7711
Copy link
Author

hey @nihal467 i have resolved conflicts again . I don't know why m seeing these conflicts some are the same conflicts which I resolved yesterday.

@rithviknishad
Copy link
Member

@nazrul7711 fix the build

image

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed merge conflict pull requests with merge conflict labels Jul 27, 2023
@github-actions
Copy link

👋 Hi, @nazrul7711,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 4, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Refactor: ConsultationDetails.tsx
3 participants