Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting Form (create + update): default to consultation category only for Patient Category #5952

Closed
wants to merge 2 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 27, 2023

WHAT

🤖 Generated by Copilot at d58ae89

Simplify the logic for setting the patient category in ShiftCreate and ShiftDetailsUpdate components. Use only the last consultation category to avoid inconsistencies and bugs.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d58ae89

  • Simplify the logic for setting the patient category in shift request components by only using the last consultation category (link, link)

@rithviknishad rithviknishad requested a review from a team July 27, 2023 10:21
@rithviknishad rithviknishad requested a review from a team as a code owner July 27, 2023 10:21
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3906619
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c279198ede640008adc551
😎 Deploy Preview https://deploy-preview-5952--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 2:03pm

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jul 27, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jul 27, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 1, 2023

@rithviknishad
image

https://deploy-preview-5952--care-net.netlify.app/facility/1193b6cb-0b31-47b8-8c5f-a5c819114359/patient/61444d60-0aaf-4aa7-9463-b7a518969f9a/consultation/7be506ef-3ea6-441b-8d4f-3bfbd3370a1b

image

  • as per the latest log-update, the patient is critical but the shifting form is getting auto-filled based on the consultation form based category

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants