Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doctor capacity dropdown in the facility creation page malfunctioning #5959

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jul 27, 2023

Bug Fix

WHAT

🤖 Generated by Copilot at 3c56b3c

Fixed a UI bug in the doctor capacity form and cleaned up imports. The bug prevented selecting the correct doctor specialization in SelectMenuV2 in DoctorCapacity.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Screenshot

image

HOW

🤖 Generated by Copilot at 3c56b3c

  • Fix a bug that prevented selecting the doctor specialization by using the id property of the doctorTypes options instead of the whole object in the SelectMenuV2 component (link)
  • Reorder the import statements alphabetically for better readability and consistency in DoctorCapacity.tsx (link)

@aeswibon aeswibon requested a review from a team July 27, 2023 20:08
@aeswibon aeswibon requested a review from a team as a code owner July 27, 2023 20:08
@aeswibon aeswibon requested a review from bodhish July 27, 2023 20:08
@aeswibon aeswibon added needs testing P1 breaking issue or vital feature labels Jul 27, 2023
@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 8:09pm

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3c56b3c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c2ceadb1755e00085b0109
😎 Deploy Preview https://deploy-preview-5959--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 9115298 into coronasafe:develop Jul 28, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctor Capacity dropdown in the facility creation page malfunctioning
3 participants