Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring command.ts file #5979

Closed
wants to merge 1 commit into from
Closed

Refactoring command.ts file #5979

wants to merge 1 commit into from

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Aug 1, 2023

WHAT

🤖 Generated by Copilot at f2c79b0

Improves login commands in commands.ts for Cypress tests. Uses aliases and local storage to manage tokens and adds error handling for token expiration.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f2c79b0

  • Remove unnecessary import of Cypress and add comment with file name (link)
  • Store tokens as alias instead of writing to file and use cy.wrap and cy.as to access them later (link)
  • Refactor loginByApi command to use helper function loginAndSetTokens that performs login and sets tokens in local storage (link)
  • Handle 403 status code in loginByApi command by refreshing tokens with loginAndSetTokens and sync refresh token from alias to local storage (link)

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 2:11pm

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f2c79b0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c912808718070008ce08dd
😎 Deploy Preview https://deploy-preview-5979--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 1, 2023
@nihal467
Copy link
Member Author

nihal467 commented Aug 1, 2023

closing it, as i need to look into it from a different approach

@nihal467 nihal467 closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant