Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html support for login page's goal #5982

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 2, 2023

WHAT

🤖 Generated by Copilot at df93c33

Added support for raw HTML in login page description. This required installing the rehype-raw package and updating the Login.tsx component to use it with ReactMarkdown.

Proposed Changes

  • Add HTML support for the markdown of custom_description. This is needed to add non-blue links in the goal.
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at df93c33

  • Add rehype-raw package as a dependency to enable raw HTML rendering in markdown (link)
  • Import rehype-raw package in Login.tsx component (link)
  • Pass rehype-raw plugin as a prop to ReactMarkdown component in Login.tsx to customize login page description with HTML tags (link)

@Ashesh3 Ashesh3 requested a review from a team August 2, 2023 05:06
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 2, 2023 05:06
@Ashesh3 Ashesh3 requested a review from gigincg August 2, 2023 05:06
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 5:06am

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit df93c33
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c9e45183b20d0007ff5cb5
😎 Deploy Preview https://deploy-preview-5982--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

LGTM

@khavinshankar khavinshankar merged commit d356575 into develop Aug 2, 2023
33 of 34 checks passed
@khavinshankar khavinshankar deleted the markdown-html branch August 2, 2023 10:58
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants