Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow negative values for Bed capacity in facility #5995

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 2, 2023

WHAT

🤖 Generated by Copilot at f54017d

This pull request enhances the BedCapacity component by adding validation checks for the bed occupancy and capacity fields. This prevents users from entering invalid negative values in src/Components/Facility/BedCapacity.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f54017d

  • Add validation checks for bed capacity fields in BedCapacity component (link, link)

@Pranshu1902 Pranshu1902 requested a review from a team August 2, 2023 21:25
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 2, 2023 21:25
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 5:41pm

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1e733c0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64cfdb09b773de000883d2ef
😎 Deploy Preview https://deploy-preview-5995--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2023

LGTM

@khavinshankar khavinshankar merged commit 47cbc02 into coronasafe:develop Aug 8, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Negative value for bed capacity
3 participants