Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added negative doctor count check for facility #5997

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 2, 2023

WHAT

🤖 Generated by Copilot at de5ad67

Validate count field in DoctorCapacity form. This change prevents negative values for the number of doctors in a facility in src/Components/Facility/DoctorCapacity.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at de5ad67

  • Add a validation check for the count field of the DoctorCapacity form to prevent negative values (link)
  • Display an error message and mark the form as invalid if the count value is negative (link)

@Pranshu1902 Pranshu1902 requested a review from a team August 2, 2023 21:33
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 2, 2023 21:33
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 9:34pm

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit de5ad67
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64cacbad4092000008d5f5e1
😎 Deploy Preview https://deploy-preview-5997--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pranshu1902 Pranshu1902 changed the title added negative check added negative doctor count check for facility Aug 3, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 7, 2023

LGTM

@khavinshankar khavinshankar merged commit fa54ca0 into coronasafe:develop Aug 8, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Negative values are allowed in Doctors list count for a facility
4 participants