Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no data issue in notice borad on hard reload #6025

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Aug 8, 2023

WHAT

🤖 Generated by Copilot at e537978

This pull request improves the NoticeBoard component by using a regular function instead of a type declaration, and fixes the caching issue of the getNotifications action by passing a timestamp as the cache key. These changes enhance the code quality and the user experience of the notifications feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at e537978

  • Invalidate cache and fetch latest notifications by passing timestamp to fireRequest (link)
  • Simplify NoticeBoard component by using regular function instead of type declaration (link)

@khavinshankar khavinshankar requested a review from a team August 8, 2023 04:37
@khavinshankar khavinshankar requested a review from a team as a code owner August 8, 2023 04:37
@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 5:27am

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 69cd6b3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64d1d20dcb787c0008508995
😎 Deploy Preview https://deploy-preview-6025--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Redux/actions.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Aug 8, 2023

LGTM

@gigincg gigincg merged commit 4f9b9b0 into develop Aug 9, 2023
29 checks passed
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-notice-hard-reload branch August 9, 2023 07:53
JahnabDutta added a commit to JahnabDutta/care_fe that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notice board is not showing any notification send to the facility
4 participants