Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoformat typed dates in DateInput #6026

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 8, 2023

WHAT

🤖 Generated by Copilot at 2481eb0

This pull request enhances the date input and date range input components by allowing flexible and consistent input and output formats. It also removes some unnecessary code and improves the focus behavior of the DateInputV2 component.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 2481eb0

  • Add displayValue state variable to store formatted date input value (link)
  • Modify input element to use displayValue and format it with slashes (link)
  • Remove unnecessary props and empty line of code from input element (link, link)
  • Set end date to start date when selecting start date in DateRangeInputV2 (link)
  • Add autoFocus prop to input element to focus it when date picker opens (link)

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Aug 8, 2023
@Ashesh3 Ashesh3 requested a review from a team August 8, 2023 07:33
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 8, 2023 07:33
@Ashesh3 Ashesh3 requested a review from bodhish August 8, 2023 07:33
@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 10:19am

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit aae5cd5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64d2165a569698000835d5cb
😎 Deploy Preview https://deploy-preview-6026--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 8, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 8, 2023

LGTM

@khavinshankar khavinshankar merged commit 8501b79 into develop Aug 8, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the date-picker-format branch August 8, 2023 15:26
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve format in date field
4 participants