Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central Nursing Station: Dynamic aspect ratio for Vitals (variable timespan based on screen size πŸ“±πŸ–₯️) #6036

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 9, 2023

WHAT

πŸ€– Generated by Copilot at 32c56e3

This pull request enhances the responsiveness and layout of the vitals monitor components in the facility views. It introduces a new custom hook useVitalsAspectRatioConfig that calculates the optimal configuration based on the screen size and aspect ratio. It also refactors and updates the existing components that use the vitals monitor to leverage the new hook. It also adds a console log statement for debugging purposes.

Proposed Changes

  • Central Nursing Station: Dynamic aspect ratio for Vitals (variable timespan based on screen size)
  • Fixed waveform overflow in mobile view

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

πŸ€– Generated by Copilot at 32c56e3

  • Add a custom hook useVitalsAspectRatioConfig to calculate the optimal configuration for the vitals monitor based on the screen size and aspect ratio (link)
  • Use the useVitalsAspectRatioConfig hook in the CentralNursingStation component and pass the config and hash values to the HL7PatientVitalsMonitor component props (link, link, link)
  • Use the useVitalsAspectRatioConfig hook in the ConsultationDetails component and pass the config and hash values to the HL7PatientVitalsMonitor and VentilatorPatientVitalsMonitor component props (link, link, link, link, link, link, link)
  • Remove the unused imports of useBreakpoints and getVitalsCanvasSizeAndDuration from the ConsultationDetails component (link)
  • Modify the font size and layout of the patient age, gender, asset, and bed links in the HL7PatientVitalsMonitor component to improve responsiveness and readability (link, link)
  • Add a console log statement to the useBreakpoints hook to debug the current breakpoint value (link)

@rithviknishad rithviknishad requested a review from a team August 9, 2023 10:39
@rithviknishad rithviknishad requested a review from a team as a code owner August 9, 2023 10:39
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
care-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 9, 2023 10:42am

@rithviknishad rithviknishad changed the title Central Nursing Station: Dynamic aspect ratio for Vitals (variable timespan based on screen size) Central Nursing Station: Dynamic aspect ratio for Vitals (variable timespan based on screen size πŸ“±πŸ–₯️) Aug 9, 2023
@netlify
Copy link

netlify bot commented Aug 9, 2023

βœ… Deploy Preview for care-egov-staging ready!

Name Link
πŸ”¨ Latest commit 0b52f73
πŸ” Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64d36d457fd473000832c1c8
😎 Deploy Preview https://deploy-preview-6036--care-egov-staging.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress failed pull request with cypress test failure labels Aug 9, 2023
@nihal467
Copy link
Member

nihal467 commented Aug 9, 2023

LGTM

@khavinshankar khavinshankar merged commit 5b8c1d3 into develop Aug 9, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the cns-vitals-dyn-aspect-ratio branch August 9, 2023 11:27
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us πŸ₯‡. We always welcome your contribution πŸ™‚, so feel free to contribute to anything anytime, and never lose that spirit of innovation πŸ™Œ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants