Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Triage table width when no data is available #6042

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 10, 2023

WHAT

🤖 Generated by Copilot at a842eed

Improved the table component and its usage in the facility home page. Refactored the code to use Tailwind CSS and React best practices, and fixed the layout of the "No Data Found" message.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at a842eed

  • Simplify style props of div elements in Table component using Tailwind CSS classes (link, link, link)
  • Add key prop to div element that renders each heading in Table component (link)
  • Adjust min-width of "No Data Found" message in Table component to match table width (link)

@Ashesh3 Ashesh3 requested a review from a team August 10, 2023 08:45
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 10, 2023 08:45
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 9:13am

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 247b626
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64d9f001696ea5000820b2ce
😎 Deploy Preview https://deploy-preview-6042--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 10, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Aug 14, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b179277 into develop Aug 16, 2023
29 checks passed
@khavinshankar khavinshankar deleted the fix-6040 branch August 16, 2023 08:04
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase the width of no data found in facility triage section
3 participants