Placed Non-waveform data above waveforms in mobile view #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM |
khavinshankar
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 5b90d4f
This pull request improves the user interface and performance of the HL7 monitor, a component that shows vital signs from external devices. It extracts the waveform rendering logic into a
WaveformCanvascomponent and updates the styling and layout of the other vitals. It also fixes a z-index issue with theMonitorConfigurecomponent by adding aclassNameprop to theCardcomponent inHL7Monitor.tsx.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 5b90d4f
HL7PatientVitalsMonitorcomponent into a reusableWaveformCanvascomponent (link)WaveformCanvascomponent in theHL7Monitorcomponent to render the waveform and the offline message (link)VitalsNonWaveformContentcomponent to match the design and the waveform canvas (link)Cardcomponent that wraps theMonitorConfigurecomponent in theAssetTypecomponent to avoid overlapping with the waveform canvas (link)