Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress maintenance fix #6128

Merged
merged 17 commits into from
Aug 24, 2023
Merged

cypress maintenance fix #6128

merged 17 commits into from
Aug 24, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Aug 21, 2023

WHAT

🤖 Generated by Copilot at 12558ce

Replaced the date of birth input component with DateInputV2 in the patient form and test. This improves the usability and reliability of the date input.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 12558ce

  • Replace the date of birth input with a new component DateInputV2 that allows typing the date (link)
  • Add an id attribute to the DateInputV2 component to match the field name in the form (link)
  • Remove the data-testid attribute from the date of birth input as it is no longer needed (link)
  • Update the test in cypress/e2e/patient_spec/patient_crud.cy.ts to use the id attribute to find and type the date of birth (link)

@nihal467 nihal467 requested a review from a team August 21, 2023 13:47
@nihal467 nihal467 requested a review from a team as a code owner August 21, 2023 13:47
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 2:02pm

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit da50c0c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e762f555bff800085f02a2
😎 Deploy Preview https://deploy-preview-6128--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 21, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Aug 24, 2023
vite.config.ts Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit 279a305 into develop Aug 24, 2023
12 of 20 checks passed
@khavinshankar khavinshankar deleted the cypress-fix branch August 24, 2023 14:02
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure discussion required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants