Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Skills with already linked to the user #6147

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 24, 2023

WHAT

🤖 Generated by Copilot at f1b4e3c

Updated the SkillSelect component to filter out the skills already assigned to a user. Passed the username prop from the SkillsSlideOver component to enable this functionality.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f1b4e3c

  • Add username prop to SkillSelect component and use it to filter out skills that are already linked to the user (link, link, link, link, link)
  • Import getUserListSkills action from ../../Redux/actions to fetch the user's skills (link)
  • Destructure username from the props parameter of SkillSelect (link)
  • Pass username prop to SkillSelect in SkillsSlideOver component (link)
  • Modify loadOptions function in SkillSelect to dispatch getUserListSkills with username and compare the skill ids with the ones returned by getAllSkills (link)

@Pranshu1902 Pranshu1902 requested a review from a team August 24, 2023 08:35
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 24, 2023 08:35
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 4:40am

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3afaeab
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e8309dd9d2b30008411d2f
😎 Deploy Preview https://deploy-preview-6147--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit e2c52e8 into coronasafe:develop Aug 30, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show Skills with already linked to the user
3 participants