Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6159; fix misalignment in option chips of async autocomplete. #6160

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 25, 2023

WHAT

🤖 Generated by Copilot at 595c28a

Refactored option chips in AutoCompleteAsync component to use a common component MultiSelectOptionChip. This enhances the UI and code quality of the form component.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 595c28a

  • Replace the custom span element for rendering the selected options in the AutoCompleteAsync component with the MultiSelectOptionChip component, which provides a consistent and reusable way to display the option chips with a remove icon and a label. (link, link)
  • Import the MultiSelectOptionChip component from ./MultiSelectMenuV2 in the AutoCompleteAsync.tsx file. (link)

@rithviknishad rithviknishad requested a review from a team August 25, 2023 15:59
@rithviknishad rithviknishad requested a review from a team as a code owner August 25, 2023 15:59
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 4:00pm

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 595c28a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e8cffef1959400088154ab
😎 Deploy Preview https://deploy-preview-6160--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3669e29 into develop Aug 30, 2023
32 of 34 checks passed
@khavinshankar khavinshankar deleted the rithviknishad-patch-1 branch August 30, 2023 04:05
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close Icon of selected options of auto complete async is bigger than intended, hence looks misaligned.
3 participants